feat: mask sensitive keys and tokens #3221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change sensitive fields (admin keys, vault tokens) from input type text to password (default) with a toggle to show/hide values
Baoyuantop
approved these changes
Oct 8, 2025
Baoyuantop
reviewed
Oct 8, 2025
Contributor
Baoyuantop
left a comment
Baoyuantop
left a comment
There was a problem hiding this comment.
We also need to add a simple test for this switch.
Contributor
|
Hi @foskey51, can you add a simple test for this modification? You can refer to the existing e2e testing process. |
The Bitnami etcd image (bitnami/etcd:3.5) is deprecated and no longer available in Docker Hub. Updated the reference in e2e/server/docker-compose.common.yml to use bitnamilegacy/etcd:3.5 instead. This resolves the dev container build failure mentioned in issue #3220.
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3 to 4. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v3...v4) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4 to 6. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v6) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
This PR addresses how sensitive fields are handled in Settings and Secrets by changing their input type to password and introducing a toggle to switch between masked and plain-text views.
Settings:
Behaviour:
Secrets (page):
Behaviour:
Related issues
fix/resolve #3218
Checklist: